A few (nit-picking) comments about general coding style (your program wil work OK without applying them, but in larger and more complicated programs, it can make a difference):
- Use single quotes whereever possible rather than double quotes. This will save you from the effects of unwanted interpolation.
- Use lexical file-handles and surround your file operations with the smalles scope possible (a loop, a block, ...). The handles will close automatically when you leave the scope.
- Use the three argument form of open, it is safer than the two argument form.
One final comment: after running your program, you now have an unneccessary "temporary"
preferences.tmp file in your system. Perhaps you can have a look at
File::Temp that can be used to create and open temporary files in a safe way and these temporary files can be made to disappear automatically once your program finishes.
CountZero
A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.