I'm not a maintainer of any popular modules, but I have had patches submitted to one or two of mine. I've also submitted patches to a few modules with some success.

There are a few things I can think of that you should think about when submitting a patch:

If I can quickly understand the change, and see the corrected behavior, I'm likely to apply the change quickly. If I'm going to have to spend a lot of time trying to decide if it's an improvement, I may put it off while I work on other things. These are not a make-or-break list. The more of them, I see the better quality I expect from the patch.

One thing to avoid is gratuitous code changes (reformatting, re-indenting, changes unrelated to the purpose of the patch). Anything that makes the patch harder to understand (or possibly apply by hand) is likely to slow down the process.

I also try to let the module maintainer know how much I appreciate the module and something (short) about how I'm using it. I am usually surprised and pleased when someone writes me about one of my modules. I find it interesting to see where they turn up.

G. Wade

In reply to Re: Patch Etiquette? by gwadej
in thread Patch Etiquette? by pileofrogs

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.