Since it is not clear to me what problem you are trying to solve, all I can offer is the following generic advice.

Provide more details regarding your problem. Is your output not what you expect it to be? Are you getting unexpected warning or error messages (after you add use warnings and use strict, as others have suggested)?

Neaten your code up with perltidy.

There are too many constructs named "product": a sub, a hash and a reference. Since you do not seem to be passing the hash around anywhere, you should consider reducing confusion by eliminating the hash variable. For example, instead of $product{id} why not just $id?

Use more parentheses to group terms of your long expressions, and then use named operators: 

if (($db eq $name) and ($comm eq $commandstop) and ($cachedel eq 'No')
+)

[download]

In reply to Re: Perl code looping using XML::Twig by toolic
in thread Perl code looping using XML::Twig by coding_new

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.