The problem is that you forgot to declare '$newvar' as a local variable, so each time through the loop the result of the previous assignment is still there.

Switch it to my($newvar), or reset it each time.

Not having local variables also means that $minlength is incremented by ('+=') a random number each time. If you want to pick a number from 5 to 15, you are a little off track.

As a creative suggestion, instead of doing all that work, why not just this? 
    my(@vchars) =(a..z,A..Z,0..9);

    sub rwg
    {       
          return join ('',
              map { $vchars[int(rand($#vchars+1))] }
                 5 .. 5+int(rand(10)));
    }

[download]
Change 5 to $minlength, 10 to ($maxlength-$minlength) if so desired.

Additionally, remember that rand() picks a number up to the maximum, which in this case is $#vchars, so the last letter will probably not get picked unless you +1 it.

In reply to Re: random number generation problem by tadman
in thread random number generation problem by cghost23

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.