"John Doe <john@example.org>" (minus the quotes) is a valid email address, but you'll have problems if $recipients contains that.

And of course, there's the malicious who might find a way of getting "| rm -rf /" (minus the quotes) into $host or $recipients.

The multiple argument form of various commands gets around that problem. 

use IPC::Open3 qw( );

open(my $mailer_fh, '|-', '/bin/mail', '-s', $hostn, $recipients)
   or die("Cannot execute mail command: $!\n");

open(my $msg_fh, '<', $disk_changes)
   or die("Cannot execute message file: $!\n");

print $mailer_fh $_ while <$msg_fh>;

close($mailer_fh)
   or die("Error sending mail message: $!\n");

$? == 0
   or die("Error sending mail message: $?\n");

[download]

In reply to Re^3: Checking mail command for success by ikegami
in thread Checking mail command for success by ronix

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.