Could this be correct or is there a more efficient way of doing it?

#...more code above, all variable previously declared and strict is al
+so been used.

push @all_names, $names;
push @email, $email;
push @local, $local;
push @year, $year;

} #end of foreach.


#Getting data

my $dbh = DBI->connect("DBI:ODBC:$myserver",$u, $p, { RaiseError => 1 
+});

my $vals = 
  join("," 
       ,map { $dbh->quote($_) } @all_names 
      );

my $year_val = 
  join("," 
       ,map { $dbh->quote($_) } @year 
      );

my $email_val = 
  join("," 
       ,map { $dbh->quote($_) } @email 
      );

my $local_val = 
  join("," 
       ,map { $dbh->quote($_) } @local 
      );

my $sql = "SELECT DISTINCT 
                               
                               name, email, addr, location
                               
               FROM            my_users
               WHERE           year IN ($year_val)   /* need all the v
+alues from @year */
               AND             email IN ($email_val) /* need all the v
+alues from @email */
               AND             location IN ($local) /* need all the va
+lues from @local */
               AND             name IN ($vals)
          ";

[download]

In reply to Re^2: DBI, MAP Help! by Anonymous Monk
in thread DBI, MAP Help! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.