I have not used strict

Why not? You obviously know about strictures so why are you not using them (see The strictures, according to Seuss)?

In general don't use local. It doesn't do what you think it does. Use my instead.

$opt2 !~ /[123] probably doesn't do what you think it does. It will match any string containing either 1, 2 or 3 as part of the string. It would match 971238 for example.

Built in functions such as chomp generally are used without parentheses: chomp $value or chomp @values.

I'd change init_input_filenames to:

sub init_input_filenames {
    my ($type) = @_;
    my $dir = ".";
    my %fileNames;

    $type ||= 'tokenized';
    
    $fileNames{plant}               ="$dir/plant.$type";
    $fileNames{plant_hist}          ="$dir/plant.$type.hist";
    $fileNames{plant_titles}        ="$dir/plant.titles";
    $fileNames{tank}                ="$dir/tank.$type";
    $fileNames{tank_hist}           ="$dir/tank.$type.hist";
    $fileNames{tank_titles}         ="$dir/tank.titles";
    $fileNames{perplace}            ="$dir/perplace.$type";
    $fileNames{perplace_hist}       ="$dir/perplace.$type.hist";
    $fileNames{perplace_titles}     ="$dir/perplace.titles";
    $fileNames{common_words}        ="$dir/common_words.$type";

    return \%fileNames;
}

[download]

which halves the code and removes a pile of global variables. The down side is that strict checking doesn't catch misspelled keys for the fileNames hash, but then, without strictures you weren't checking those anyway! At least by using the hash technique you make it clearer where the names are used and where they come from.

True laziness is hard work

In reply to Re: Help with a perl code by GrandFather
in thread Help with a perl code by varunreeves

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.