Someone else pointed out that you have a recursion loop.

Reading the code, I think you would benefit from given/when instead of a cascade of elsif statements.

But... maybe you should make a hash as a keyboard mapping. This will not only make your loop simple as all the logic is elsewhere, but allow you to remap the keyboard.

my $key = ReadKey(-1);
next unless defined $key;  #next or return depending on your code stru
+cture
if ($key eq "\e") { #expecting more
   $key .= ReadKey(-1);  # should be a '['
   $key .= ReadKey(-1);
   }
my $callback= $keymap{$key};
if (defined $callback) {
   $callback->($key);
   }
else { beep(); }  #no such key is meaningful here

[download]
That is, the gathering is centralized, and separate from the code dispatched to. The $key is passed as an argument in case you have common subs for several keys and need to distinguish between them.

—John

In reply to Re: Most efficient design by John M. Dlugosz
in thread Most efficient design by cdlaforc

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.