I've written a script to convert some data files into a new format but when I run the script it tells me "Setuid/gid script is writable by world". I've tried to eliminate taint but I'm still getting the problem. Where am I missing the taint in my code?

#! /usr/bin/perl
use File::Copy;

################################################
#                                              #
# program to convert old pdb files to a usable #
# format.                                      #
#                                              #
################################################

foreach my $pdb (@ARGV) {
    if ($pdb =~ /(.+?).pdb$/ && -e $pdb) {
        $pdb = $1;
#        $pdb = substr($pdb, 0, -4);
        open(IN, "<$pdb.pdb");
        open(OUT, ">$pdb.tmp");
        while(<IN>) {
            if ($_ =~ /^\S+\s+\d+\s+(\D)/) {
                my $line = $_;
                chomp($line);
                print OUT "$line           $1\n";
            }
            else {
                print OUT $_;
            }
        }
        close(IN);
        close(OUT);
        move("$pdb.pdb", "$pdb.pdb.old");
        move("$pdb.tmp", "$pdb.pdb");
        print "converted $pdb.pdb. the old file has been saved as $pdb
+.pdb.old\n";
    }
    elsif (! -e $pdb) {
        print "file $pdb does not appear to exist\n";
    }
    else {
        print "file $pdb is not a .pdb file or there was an unknown er
+ror\n";
    }
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.