If it were my module, I would not export anything by default. Default exports are rather evil. When somebody comes along and reads the code:

all_plans_okay();

how do they find where this subroutine is defined? Well, that becomes obvious when the code above it is:

use Test::NoPlan qw( all_plans_okay );

I also find the module name implies nearly the opposite of what it does. I would rename it Test::AllPlans or similar.

I'd also never use the module since I have no problems just settings the 'plan' to some arbitrary number when I first start writing it and then fixing it as a final step. I never do a temporary "no plan". (It took me a while to realize what the motivation for the module was.)

But thanks for contributing this. I hope you find the feedback useful despite its shortcomings. :)

- tye        


In reply to Re: RFC: Another test module - Test::NoPlan (NoNoPlan) by tye
in thread RFC: Another test module - Test::NoPlan by duncs

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.