If it were my module, I would not export anything by default.

I have tried to write the module according to PBP (trying to improve my coding skills) and I just reread the section of it about exporting which suggests that since this one method will always be used by the programmer it should be exported by default. Also, since the test file it is in may only be a few lines long it seems reasonable for programmers to sumise where the method came from, so I think it may be better to export the one routine by default.

I also find the module name implies nearly the opposite of what it does. I would rename it Test::AllPlans or similar.

Until you pointed this out I didn't realise the name was a bit ambiguous - in my mind the name is 'Test-for-no-plan' which seemed to fit what it was about best - 'test-all-plans' implies to me that it does more than just checking to see if 'no_plan' has been used.

Its one of those that I can see both sides of the argument, so in the long run I am not sure which might be best.

I hope you find the feedback useful despite its shortcomings. :)

This is the first module I have written from scratch for use on CPAN so if this is the 'worst' of the feedback I am actually quite happy about the points raised so far - after all, it is about improving my own coding skills rather than just throwing something on CPAN :)

Duncs

In reply to Re^2: RFC: Another test module - Test::NoPlan (NoNoPlan) by duncs
in thread RFC: Another test module - Test::NoPlan by duncs

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.