My understanding of the changes Jamie made included session-awareness (making every request unique; I've noticed this when I fire up Firefox after a crash...Webmin refuses to respond to the requests to reload the old pages, despite the fact that the session data is provided by Firefox on recovery and most sites remain logged in). I'm not actually involved in that aspect of the code, but there were CSRF protections added at the same time (as you say, they go hand in hand). But I'll poke around a bit to make sure there's actually protection against them.

I'm pretty deeply ignorant about XSS and CSRF, but there was an audit performed by a security research company a while back which found that batch of vulnerabilities. CSRF was certainly a known attack vector at the time, so I'm pretty sure it was among the exploits covered.

In reply to Re^5: Secure Webmin by SwellJoe
in thread Secure Webmin by pileofrogs

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.