Your code seemingly intentionally finds something other than the TLD in some situations.
- http://www.ibm.com/ ⇒ com (ok)
- http://www.ibm.ca/ ⇒ ibm.ca (not tld)
- http://www.ibm.co.uk/ ⇒ co.uk (not tld)
It also mishandles a number of the valid urls listed below. Fix:
$url = URI->new($url);
defined( my $host = $url->host() )
or die("No host\n");
my $tld;
if ($host =~ /\./) {
$tld = /\.([^.]+)$/;
$tld =~ /[a-z]/i
or die("No domain\n");
} else {
$host =~ /[a-z]/i
or die("No domain\n");
$tld = 'localdomain';
}
Handles valid urls
- http://example.com/ (com)
- http://example.com./ (com)
- http://example.com (com)
- http://example.com:80/ (com)
- http://example/ (localdomain)
- http://www.ibm.com/ (com)
- http://www.ibm.ca/ (ca)
- http://www.ibm.co.uk/ (uk)
- http://www.ibm.com.au/ (au)
- http://192.168.0.1/ (error)
- http://3232235521/ (error)
Invalid urls aren't necessarily detected.
Update: Updated code to detects an invalid url it didn't detect before.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.