Well, yes it's possible to do it using something like your approach. Your file_merge() subroutine would look like this:

sub file_merge {
  my $hash_ref = shift;
  while (<>) {
    chomp;
    my ($key, @values) = split /-/, $_;
    push @{$hash_ref->{$key}}, [ @values ];
  }
}

[download]

But actually, that's not right as you're reading from the default filehandle each time.

I'd do this completely differently.

sub file_merge {
  my $filename = shift;

  open my $fh, '<', $filename
    or die "$filename: $!\n;

  my %hash;
  while (<$fh>) {
    chomp;
    my ($key, @values) = split /-/, $_;
    push @{$hash{$key}}, [ @values ];
  }

  return %hash;
}

[download]

You would then call it like this:

my %msisdn = file_merge('/tmp/subscription_list');
my %calls  = file_merge('/tmp/Call_Det');

[download]

Another (perhaps better) alternative would be to return a hash reference rather than a hash.

As always strict and warnings will point out some of the major problems with your code.

--

See the Copyright notice on my home node.

Perl training courses

In reply to Re: hash as subroutine argument by davorg
in thread hash as subroutine argument by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.