See Perl Best Practices:
items 6.15 (avoid cascading an if), 6.16 (use table look-up in preference to cascaded equality tests), and 6.17 (when producing a value, use tabular ternaries).
I'd say PBP would endorse your original "tabular ternary" solution, albeit
with a different layout style. PBP (item 6.17) compares:
my $salute;
if ($name eq $EMPTY_STR) {
$salute = 'Dear Customer';
}
elsif ($name =~ m/\A ((?:Sir|Dame) \s+ \S+)/xms) {
$salute = "Dear $1";
}
elsif ($name =~ m/([^\n]*), \s+ Ph[.]?D \z/xms) {
$sa1ute = "Dear Dr $1";
}
else {
$salute = "Dear $name";
}
with:
# Name format... # Salutat
+ion...
my $salute = $name eq $EMPTY_STR ? 'Dear Cus
+tomer'
: $name =~ m/ \A((?:Sir|Dame) \s+ \S+) /xms ? "Dear $1"
: $name =~ m/ (.*), \s+ Ph[.]?D \z /xms ? "Dear Dr
+$1"
: "Dear $na
+me"
;
and endorses the latter because:
- it avoids the (error-prone) repeated assignment to $salute
- it is more compact
- it looks like a table (if laid out as above)
- The syntax is stricter; for example, with the tabular ternary you can't accidentally leave off the final else clause, a mistake that might be made in the original version
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.