Hi, I replied earlier with the ^-> negated character class. I just noticed your code at top, you might want to consider replacing this:
if (/\<img src=(???)-disclose.gif(.*)\>/i) {
$_ = "";
with this: (note: the improved regex is inserted below)
lc; #Much more efficient than having the regex do it
s/\<img\s*src\s*=[^->]-disclose.gif[^>]*>//g;
#more effecient to use a substitution
Please note that I used the lc function, because having the regex perform case insensitive searching is a lot of overhead, also I changed your $_ = "" to a substition, which is also more effecient. Also, if you had more than one img tag on a line before, the whole line would have been deleted if even one of the tags had the -disclose.gif text in them. Also I changed the end of the regex. Instead of matching the rest of the string with
(.*)\>
I used the negated character class ^>. Again, the .* is greedy, so it could have matched other img tags on the same line, for that mater, it could have matced anything on the same line.
The 15 year old, freshman programmer
Stephen Rawls
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.