Well, let me point out some of the many problems with that script.
- There is no use strict;
- There is no use warnings;
- The reserved words my and unless are in ALL CAPS
- The functions lc and s/// are in ALL CAPS
-
There is a bareword (HTTP_REFERER)
- The regex has some unnecessary grouping parentheses
- The function ErrorHTML is not defined
Let me re-write it using some Perl Best Practices:
use strict;
use warnings;
# Just the domain name, no "www."
my $AuthorizedDomain = lc 'example.com';
my $FormDomain = lc $ENV{'HTTP_REFERER'};
$FormDomain =~ s{
\A
https?:// # Strip off the protocol
(?:www\.)? # Strip off any "www."
(.*?) # Grab everything before...
/ # The first slash
.* # And delete the rest
\Z
}
{
$1
}msx;
if ($FormDomain ne $AuthorizedDomain) {
ErrorHTML('Unauthorized access.');
}
Of course, for this to really work, the ErrorHTML function would have to be defined somewhere.
Update: Removed #5. Thanks, Your Mother.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.