I am working on a script where I am suppose to run some command and if it fails generate the log file and this is what I have done,
system($command);
if ($? == -1 )
{
$step = $step -1;
display_err($command,$step);
exit;
}
sub display_err
{
my ($cmd,$step)= @_;
open(LOG, ">>release_log.log")|| die "Unable to open release_log.log f
+or output: $!\n";
print LOG <<HEADING;
==================================================================
HEADING
print LOG "[Command Execution Failed]\n";
print LOG "Command: $cmd\n";
print LOG "Command Succeful upto: $step\n";
print LOG scalar localtime();
close LOG;
}
Any body have any suggestion how can I make it more Perlish?Please,
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.