There are many ways to refactor that code to make it easier to maintain. If the work to be done is really as light weight as is indicated then I'd tend toward a light weight object approach:

use strict;
use warnings;

my $obj = bless {};

$obj->processLine ($_) while <DATA>;
$obj->report ();

sub processLine {
    my ($self, $line) = @_;

    return if $line !~ /^M/;
    chomp $line;

    my $filename = (split '/', $line)[-1];

    return if ! defined $filename;
    $self->{files}{$filename} ||= $line;
}


sub report{
    my ($self) = @_;

    print "People not found\n" if ! exists $self->{files}{'people.pdf'
+};
    print "animal not found\n" if ! exists $self->{files}{'animal.pdf'
+};
    print "MSI not found\n" if ! exists $self->{files}{'setup.msi'};
}


__DATA__
M/people.pdf
M/wiggles.pdf
M/setup.msi

[download]

Prints:

animal not found

[download]

which scales nicely as you need to detect more or fewer file names, but could easily be changed to use a dispatch table in the 'report' section to handle more work for each found file.

True laziness is hard work

In reply to Re: Perlish while loop by GrandFather
in thread Perlish while loop by Sun751

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.