Perl allows postfix flow control, which would tighten this up a bit. Personally, I also find this version much more readable, but there are those who would disagree:
... $people = 1 if ($filename eq 'people.pdf'); $animal = 1 if ($filename eq 'animal.pdf'); $msi = 1 if ($filename eq 'setup.msi'); } } print "People not found\n" unless defined $people; print "animal not found\n" unless defined $animal; print "MSI file not found\n" unless defined $msi; ...
rovf's suggestion with using a hash to store the mapping of filenames to file descriptions is definitely the way to go for longer-term maintenance, since it allows you to expand the range of things you're looking for by simply adding a new hash entry, turning this into:
my %filenames = ( people.pdf => 'Person', animal.pdf => 'animal', setup.msi => 'MSI file', ); ... for (keys %filenames) { delete $filenames{$_} if $filename eq $_; } } } for (values %filenames) { print "$_ not found\n"; } ...

In reply to Re: Perlish while loop by dsheroh
in thread Perlish while loop by Sun751

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.