You could make your key pair (item+name, user+id) a parameter of a generic 'get' subroutine, but you would still have to figure out how to compare the values associated with the second key. You would also have to make sure that your $this object is initialized with all the possible keys (item, user) so that you can detect typos (and same for $user, $item objects). Something like this to get you started: 
sub get_by_string {
   my ($this, $field, $property, $value) = @_;
   die "Invalid field $field" if (!exists $this->{$field});
   return grep { $_->{$property} eq $value } @{$this->{$field}};
}

sub get_by_number {
   my ($this, $field, $property, $value) = @_;
   die "Invalid field $field" if (!exists $this->{$field});
   return grep { $_->{$property} == $value } @{$this->{$field}};
}

[download]
Your get calls would then look like this: 
my @items = $obj->get_by_string('item','name',$name);
my @users = $obj->get_by_number('user','id',$id);

[download]

In reply to Re: efficient getters in module (class) by roubi
in thread efficient getters in module (class) by odrevet

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.