The push array is a problem. Insert print "<@output>\n" after the second while loop and you will see that @output is emtpy or nearly empty. Because it has only the result of the last line in it.

I see you changed something in the first loop. Putting the whole line into %rs with  $rs{$line}= $position; is wrong. You have to store the rsxxx as key otherwise you won't find anything.

Here is the code that is working, at least with my test data. Note that this is exactly your version from two days ago with 'Close' changed to 'close' and the line with the grep changed to use push and without the 'my'. If that isn't working for you it means I'm operating on different data than you

#!/usr/bin/perl -w
use strict;
my$line;
my@fields;
my@output;
open (FILE1, 'snp.txt') or die "can't open the file: $!";
open (FILE2,'chr22.txt') or die "can't open the file: $!";
open (FD, '>test.txt') or die "can't open the file: $!";
my $position = tell(FILE2);
my %rs;
while ($line=<FILE2>) {
  my ($key)= $line=~/^(rs\d{5,})\b/;
  if (defined $key) {
  $rs{$key}= $position;
  }
  $position=tell(FILE2);
}
while (defined ($line= <FILE1>)) {
    my@fields= split (/\s+/ ,$line);
    push @output, grep /^rs\d{5,}\b/ ,@fields;
}
        foreach (@output) {
              if (exists $rs{$_}) {
                seek(FILE2,$rs{$_},0);
                my $line= <FILE2>;
    print FD $line;

    }
}
close FILE1;
close FILE2;
close FD;

[download]

In reply to Re^5: General program and related problems by jethro
in thread General program and related problems by micky744monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.