It would seem that a lot of this script is copied and pasted. From my own experiences, this usually ends up taking far more time debugging, than starting from scratch...

Without seeing more of your script and data, (please reply with further info), I suspect that you might simply need to chomp the $_ assigned from @nup.


Eg. 

open (USERS, ">", $users) or die "Cannot open $users: $!";
        foreach (@nup){
#       print "$genpass[0]\n";  <==this works
        s/xyz456/$genpass[0]/;  <==this gets uninitialized
        #print USERS;
        $a = shift(@genpass);
}

[download]
becomes 

open (USERS, ">", $users) or die "Cannot open $users: $!";
foreach (@nup){
    chomp;
    print "$genpass[0]\n";   
    s/xyz456/$genpass[0]/;   
    #print USERS;
    $a = shift(@genpass);
}

[download]

In reply to Re: Why do I get uninitialized value in substitution (s///) in my array? by desemondo
in thread Why do I get uninitialized value in substitution (s///) in my array? by xjlittle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.