I would probably write your script something like the following, avoiding the problem of how many passwords to generate.

use strict; use warnings; my $users = "new.users"; open(my $in, '<', $users) or die "Cannot open $users: $!"; my $tmp = $users . '.tmp'; open(my $out, '>', $tmp) or die "Cannot open $tmp: $!"; foreach (<$in>) { if(/^userPassword: xyz456$/) { my $pw = generatePassword(10); s/^userPassword: xyz456/userPassword: $pw/; } print $out "$_"; } close($out); close($in); unlink($users) or die "unlink($users): $!"; rename($tmp, $users) or die "rename($tmp, $users): $!"; exit(0); sub generatePassword { my $length = shift; my $password = ""; my $possible = 'abcdefghijkmnpqrstuvwxyz23456789ABCDEFGHJKLMNPQRST +UVWXYZ'; while (length($password) < $length) { $password .= substr($possible, (int(rand(length($possible)))), 1); } return $password }

In reply to Re^3: Why do I get uninitialized value in substitution (s///) in my array? by ig
in thread Why do I get uninitialized value in substitution (s///) in my array? by xjlittle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.