It is just a personal preference, but i would make a little sub that would package away the addition, and do the input checking (i.e. remove any non-digits, warn if the number is -1000_000, or any other of the situations pointed out) and provide helpful errors if anything is bad.


use warnings;     ## or die!
use strict;       ## seriously - don't anger the gods
use diagnostics;  ## but if you do, make them tell you why (patiently)
+...

if (my $big_int = big_int('101_dalmations') ){
  ... it was OK so go ahead and play ...
}
else {
  ... no need for this bit, error messages already generated! ...
  ... maybe you want to do something else though? ...
}

### SUBS ###

sub big_int{
  my $input = shift;
  ## check for any source of errors
  if ( $input =~ /\D/ ){
    ## non-digits - argh!
    warn "$input contains non digits\n";
    return 0;
  }
  elsif (... something else ...){
    ...
  }

  return ($input + 1000_000);
}

[download]

It just means that what you are actually trying to achieve (make a big int) remains clear, while also handling the errors nicely if they don't conform etc...

Just MHO though...

Just a something something...

In reply to Re: Style and warnings by BioLion
in thread Style and warnings by api

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.