I don't have much time at the moment to review the code specifically, but hopefully what I've done may help a bit.

I think that you should be passing your args into the sub, instead of using global vars. This causes much grief, beyond the problems it would cause if you wanted to move the sub to a library file. Also, prototypes within Perl functions don't do what most think they do. I can't think of a single link that describes this, but the archives, and Google explains it well

I quickly put the following working code snip together to hopefully give you some ideas. It was hard to tell what you meant by "it wouldn't compare them" without knowing what you expected as a result:

#!/usr/bin/perl

use strict;
use warnings;

my $mtime =
        ( stat ( "/home/steve/devel/ISP/lib/ISP/User.pm" ))[9];

my $other_mtime = 999999999;

my $cmp_result = compare ( $mtime, $other_mtime );

print "$cmp_result\n";

sub compare {

        my ( $mtime, $other_mtime, ) = @_;
        my $cmp_result;

        if ( $mtime > $other_mtime ) {
                $cmp_result = "mtime_is_higher";
        }
        else {
                $cmp_result = "mtime_is_lower";
        }
        return $cmp_result;
}

[download]

Hope it helps a bit

Steve

In reply to Re: Compare script by stevieb
in thread Compare script by TheRedcoat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.