An interesting solution to an interesting problem.

I noticed you didn't use warnings; putting them in gives this:

Use of uninitialized value in concatenation (.) or string at x.pl line + 47. Use of uninitialized value in concatenation (.) or string at x.pl line + 47. ...
But you can fix it as easily as changing the line:
$w_columns{$w_col_ix} = "$w_columns{$w_col_ix}${w_pad}${w_char}";

to:

$w_columns{$w_col_ix} .= "${w_pad}${w_char}";

Then, for fun, I tried golfing it.  Assuming the second parameter will almost always be spaces, I changed it from a string to the number of spaces (but left the default at 2).

Here's my result:

use strict; use warnings; my $a_rows = [qw[one two three four five six seven eight nine ten]]; my $npad = 4; my $justify = 1; rows_to_cols($a_rows, $npad, $justify); sub rows_to_cols { my ($x, $p, $j) = @_; my $m = 0; map { $m = length $_ if $m < length $_ } @$x; ($j||0) && map { $_ = sprintf "%*s", $m, $_ } @$x; @_ = map { ($")x($p||2),$_ } @$x; map { map { print substr($_, 0, 1, "") || $" } @_; print $/ } 1..$ +m }

And here's what's happening:

sub rows_to_cols { my ($x, $p, $j) = @_; my $m = 0; map { $m = length $_ if $m < length $_ } @$x; ## # Assigns to $m the maximum length of any word ($j||0) && map { $_ = sprintf "%*s", $m, $_ } @$x; ## # If bottom-justifying, converts every word to the # right-justified version of the same. Thus: # # [ [ # 'one', ' one', # 'two', ' two', # 'three', 'three', # 'four', ' four', # 'five', => becomes => ' five', # 'six', ' six', # 'seven', 'seven', # 'eight', 'eight', # 'nine', ' nine', # 'ten' ' ten', # ] ] @_ = map { ($")x($p||2),$_ } @$x; ## # Creates (in @_) vertical padding between each word. # For example: # [ # ' ', # ' ', # ' ', # ' ', # ' one', # ' ', # ' ', # ' ', # ' ', # ' two', # ' ', # ' ', # ' ', # ' ', # 'three', # ' ', # ' ', # ... # ' ', # ' ten' # ] # Note that the data is now in a horizontal format that, # if converted to the vertical equivalent, would be the # the desired result. map { map { print substr($_, 0, 1, "") || $" } @_; print $/ } 1..$ +m ## # This does the magic horizontal to vertical conversion }

s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

In reply to Re: Print array vertically (in columns) by liverpole
in thread Print array vertically (in columns) by perlofwisdom

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.