Small suggestion..I would get rid of both the map{} and the grep{}. Both of these things use anon lists and at the end of day, some @anon_list gets pushed onto @lines. A simple loop that doesn't use these constructs should be faster.
while (<$fh>)
{
if (/Running|Dump|FromCB|Update/o)
{
push ( @lines, filterLog($_) );
}
}
Update:
push @lines, grep { /Running|Dump|FromCB|Update/o && filterLog($_) } <
+$fh>;
Is a good idea, but don't think that it works. @lines needs to get the output of filterLog(). Grep is just a simple "filter", so this would need to be a map{} otherwise looks like you always get the value of <$fh> when the value of the grep statement is "true"?
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.