Trying to put an array into a scalar doesn't make much sense. It was deemed that when you attempt to evaluate an array as a scalar, you get its length.
Other issues:
- $file is a global variable. Use my!
- @tokens is a global variable. Use my!
- DATA is a global variable. Use my!
- You're hiding errors (including the previous three) by not using use strict; use warnings;.
- Since DATA is a global variable and you never explicitly close the file handle, the file handle is left open much longer than it needs to be.
- DATA is the name of special file handle. Let's not use that.
- What is a sub that reads a file doing printing?
- Modules are given the .pm extension.
- Why are you interpolating $file into a string (i.e. "$file") instead of just passing $file to open?
- Using open's 3-arg open is safer and less problematic.
- There's no reason to include the line number of the error in IO error message.
# Packagetest.pm
package Packagetest;
sub ReadFile
{
my ($fn) = @_;
open(my $fh, '<', $fn)
or die("Can't open file \"$fn\": $!\n");
my @recs;
while (<$fh>) {
chomp;
my @tokens = split /\|/;
push @recs, \@tokens;
}
return \@recs;
}
1;
#!/usr/bin/perl -w
use strict;
use warnings;
use Packagetest;
my $recs = Packagetest::ReadFile("datafile");
for my $rec (@$recs) {
print "Wrestlername: $recs->[0]\n";
print "Crowdreaction: $recs->[1]\n";
print "Specialmove: $recs->[2]\n";
print "\n";
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.