You're using one of my pet-peeve style errors:

sub random_alignment {
  my $type = shift;
  if ($type eq 'parts') {
    return $parts[rand @parts];
  }
  elsif ($type eq 'good_vs_evil') {
    return $good_vs_evil[rand @good_vs_evil];
  }
  elsif ($type eq 'lawful_vs_chaotic') {
    return $lawful_vs_chaotic[rand @lawful_vs_chaotic];
  }
[download]

After a return there can never be an else. the sub returns, so this much better reads like this:

sub random_alignment
{
  my $type = shift;
  if ($type eq 'parts') {
    return $parts[rand @parts];
    }
  if ($type eq 'good_vs_evil') {
    return $good_vs_evil[rand @good_vs_evil];
    }
  if ($type eq 'lawful_vs_chaotic') {
    return $lawful_vs_chaotic[rand @lawful_vs_chaotic];
    }
[download]

And personally, I'd go even further:

sub random_alignment
{
  my $type = shift;
  $type eq "parts"             and return $parts[rand @parts];
  $type eq "good_vs_evil"      and return $good_vs_evil[rand @good_vs_
+evil];
  $type eq "lawful_vs_chaotic" and return $lawful_vs_chaotic[rand @law
+ful_vs_chaotic];
[download]

Clean, short code. Beautiful, right?

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.