Please suggest how to improve my code. My function
lchompx basically removes several occurences of a certain string from the beginning of another string. For example,
$r=lchompx('abababcdef','ab') sets
$r to
'bcdef'. The details, however, are tricky:
- If lchompx is invoked with only one argument, this argument is the string to be removed, and the function operates on $_, i.e. $_='abc';$r=lchompx('a') sets $r to 'bc'.
- If it is invoked without arguments, leading multiple occurences of newline, "\n" are removed from a copy of $_.
- In void context, the argument of lchompx is changed in place, i.e. ...; lchompx($x,'abc'); modifies $x and ...; lchompx('abc'); lchompx both modify $_
.
Here is my implementation:
sub lchompx {
my $lchompstr=quotemeta(@_ > 0 ? $_[-1] : "\n");
my $change_in_place=!defined wantarray;
my $default_argument=(@_<2);
unless($change_in_place) {
@_ = $default_argument ? $_ : @_;
}
if($change_in_place && $default_argument) {
s/^($lchompstr)*//
} else {
$_[0] =~ s/^($lchompstr)*//
}
$_[0]
}
This seems to work, butit is ugly, since the substitution expression has to be repeated for the special case "Changing $_ in place". Any idea how to code this in a nicer way?
--
Ronald Fischer <ynnor@mm.st>
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.