Instead of @line having only those elements from @sfile matching each $script variable, @line is a duplicate copy of @sfile.

That's incorrect. That should read

Because @line only has those elements from @sfile that match each $script variable, @line is a duplicate copy of @sfile.

One of your patterns is apparently matching every line. Specifically, your last pattern is matching every line (since only the results of the last pattern are kept).

Here are the problems you do have:

• while (<SOURCE>) {
     $script = <SOURCE>;
  [download]

  skips every second line. I think you want

  while (my $script = <SOURCE>) {
  [download]

• You are only keeping the lines that match last pattern. If you want the lines matched by any pattern, change

  @line=grep( /$script/, @sfile );
  [download]

  to

  push @lines, grep( /$script/, @sfile );
  [download]

  But that's not good enough. If two patterns can match the same line, you'll end up with duplicate lines in @line. You want something like

  @line = grep( /$script[0]|$script[1]|.../, @sfile );
  [download]

• Why are you appending to (awfully named) newfile.txt?

• Finally, you're using global variables all over the place. Start by using use strict;, and fix the errors that were previously hidden and fix the file handles too.

Solution:

#!/usr/bin/perl -w

use strict;

my $pat_qfn = '30.txt';
my $in_qfn  = 'searchfile.txt';
my $out_qfn = 'newfile.txt';

my $pat;
{
    open(my $pat_fh, '<', $pat_qfn)
        or die("Can't open pattern file $pat_qfn: $!\n");

    chomp( my @pats = <$pat_fh> );

    ($pat) =
        map qr/$_/,
        join '|',
        @pats;
}

open(my $in_fh, '<', $in_qfn)
    or die("Can't open input file $in_qfn: $!\n");

open(my $out_fh, '>', $out_qfn)
    or die("Can't create output file $out_qfn: $!\n");

while (<$in_fh>) {
    print $out_fh $_ if /$pat/;
}
[download]

Of course, if you don't mind specify the input and outfile files on the command line, the program becomes much simpler and much more flexible.

#!/usr/bin/perl -w

use strict;

my $pat_qfn = shift(@ARGV);

my $pat;
{
    open(my $pat_fh, '<', $pat_qfn)
        or die("Can't open pattern file $pat_qfn: $!\n");

    chomp( my @pats = <$pat_fh> );

    ($pat) =
        map qr/$_/,
        join '|',
        @pats;
}

while (<>) {
    print if /$pat/;
}
[download]

filter 30.txt searchfile.txt > newfile.txt
[download]

Update: Fixed typo in var name

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.