Esteemed Monks,

This script I wrote to make two hashes and then search one hash with the keys from the other is only returning the correct result for the last key in the hash being searched. Additionally, it is taking a long time to run. I have reached the limits of my ability in trying to troubleshoot this. Any wisdom received from you will be much appreciated. 

#!/usr/bin/perl -w
#GIDgiver.pl

#this script reads gene symbols and assigns the matching Entrez GeneID
+ to each gene


use strict;

open FH1, 'GID_GeneSymbol.txt', or die "Can't open GID file\n";
open FH2, 'CVD_genelist.txt', or die "Can't open CVD gene list\n";


our (@list1, @list2, @temp);
my %GID = ();
my %CVDgenes = ();

while (<FH1>){
    chomp;
    push (@list1, $_);
    foreach (@list1){
    @temp=split(/\s+/, $_);
    }
    %GID = map { $temp[0] => $temp[1] } @temp;

}

while (<FH2>){
    chomp;
    push (@list2, $_);
    }
    %CVDgenes = map { $_ => 1 } @list2;


while ((my $k, my $v) = each(%GID)) {
    if  (exists ($CVDgenes{$v})){
    print "The GID for gene $v is $k\n";
}}

[download]

In reply to hash lookup by dr_joe

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.