Just wondering if the following definition of a sub within a sub is good form or not: 

#!/usr/bin/perl -w
#
#  Declare (and call) a sub within a sub.

use strict;
use warnings;

{
    print "In the mainline.\n";

    sub level1 {
        print "Inside level1!\n";
    }
    level1();
    print "Finished!\n";
}

[download]
It seems that perlcritic isn't happy with it: 
foo@bar:~/dev$ perlcritic --severity=4 subinsub.pl
Subroutine does not end with "return" at line 11, column 5.  See page 
+197 of PBP.  (Severity: 4)

[download]
I think this means that it thinks I'm defining a new sub, the old one wasn't terminated properly.

It does produce the output I was expecting: 

foo@bar:~/dev$ perl -w subinsub.pl
In the mainline.
Inside level1!
Finished!

[download]
Thoughts? Feedback?

Alex / talexb / Toronto

"Groklaw is the open-source mentality applied to legal research" ~ Linus Torvalds

In reply to Defining a sub within a sub: OK? by talexb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.