In addition to what jakobi said above, you might also want to check the return value of Net::Telnet::Cisco->new(). Maybe it wasn't able to establish a connection!

Also, if ( EXPRESSION ) { } else { ... } doesn't earn a beauty award either. I'd suggest you rewrite the whole foreach block like this:

foreach (@matches) {
    chomp;
    print "'$_'\n";
    my ($p1, $p2) = get_p();
    if (my $session = Net::Telnet::Cisco->new(Host => $_) ) {
        $session->login('myname', $p1);
        warn "Can't enable: " . $session->errmsg
          unless $session->enable($p2);

        my @version = $session->cmd('show version  ');
        print @version, "\n";
    }
    else {
        die "Couldn't connect to $_";
    }
}
exit;

[download]

However, I'm having this hunch that the version thingy is going to be the same for each iteration, so you might also want to consider something like this:

my @version;
foreach (@matches) {
    ....
    @version ||= $session->cmd('show version  ');
}
print @version, "\n";

[download]

In reply to Re: Global symbol "$session" requires explicit package name by muba
in thread Global symbol "$session" requires explicit package name by WearyTraveler

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.