It's tough to figure out what is trying to be done,
but here is my stab at a rewrite:
$infile = shift || die "Need a filename!\n";
open(INFILE, "$infile") || die "Could not open $infile: $!\n";
while(<INFILE>) {
chop;
tr/A-Z/a-z/; ## lowercase all characters
s/\s+/ /g; ## remove extra spaces
for $x (split(/\d*\./, $_)) {
## Set each to "0" if not found in the hash:
$site = $site{$x} || "0";
$specimin = $specimin{$x} || "0";
$procedure = $procedure{$x} || "0";
## Do not go on if any were not found:
next unless ($site && $specimin && $procedure);
## Grab the results of assigncode:
$code=&assigncode($site,$specimen,$procedure);
## Exit while loop if a good $code is found:
last if $code;
}
}
close(IN);
print "$code " if $code;
print "$line\n";
Notes:
- You don't need all the subs. Looks like you are coming from a C background?
- The whitespace substitution needs a 'g' on the end
- All the things that btrott noted above
- The subroutines were missing closing brackets
- Parenthesis on 'my' must be to the left of the equal sign:
my(@sample)=@_;
- You don't need to sort they keys if you are just looping through to
look for a specific value, unless the matches are more likely to
be found at the start of the alphabet
- Adding a chop is probably a good idea, or you get a newline on
the final value returned from the split
- The above code assumes that you have &assigncode and $line defined
elsewhere.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.