The error message is poor. It's being triggered by the the first argument of read. It should be a file handle, but isn't. Fix: 
sub upload_file {
  my ($g, $q, $readpath, $writepath) = @_;

  my $rfh;
  if (!open($rfh, "<", $readpath)) {
    $g->errorpage($q, "Could not open file '$readpath': $!\n");
    return 0;
  }

  my $wfh;
  if (!open($wfh, '>', $writepath)) {
    $g->errorpage($q, "Error creating file '$writepath': $!\n");
    return 0;
  }
  
  binmode($rfh);
  binmode($wfh);

  while (read($rfh, my $buf, 4*1024)) {
    print $wfh $buf;
  }

  close($wfh);

  chmod 0600, $writepath;

  return 1;
}

[download]

I got rid of your $| manipulation since you don't even use STDOUT.

I got rid of the sub's prototype. Not only should prototypes be avoided in general, it was completely wrong forcing you to bypass it elsewhere by wrongly adding "&" to sub calls.

In reply to Re: File Upload - Strict Ref Issue by ikegami
in thread File Upload - Strict Ref Issue by Heffstar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.