Hello esteemed monks, I was using the perl critic on the code below....

eval {
      #
      # Prepare the SQL Statment
      #
      my $sth = $dbh->prepare($sql) or die "Can't prepare SQL statemen
+t: $DBI::errstr";

      #
      # Execute the SQL Statment
      #
      my $rc = $sth->execute(@values) or die "Can't execute SQL statem
+ent: $DBI::errstr";

      #
      # Fetch the result
      #
      $data = $sth->fetchall_arrayref({});

      $sth->finish;

      #
      # check for problems which may have terminated the fetch early
      #
      die "Can't query result: $sth->errstr" if $sth->err;
   };

   if ($@) {
      print STDERR "ERROR [query_database()]: $@";
      return 0;
   }

[download]

I got the notice that "You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed."
Is that because this traps the last syntax error and not warning messages?. Any advice on $@ would be appreciated.



Got a LOT of great answers. Monks you are the best!

In reply to $@ can't be relied on? by sherab

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.