Unless I'm mistaken, both 'keys' and 'values' will make Perl gather up all the elements of each into temporary lists before even attempting to assign them. If %source is really huge, then that could be a problem?

If I thought memory use was a concern I'd walk the key values instead.

while (my($key, $value) = each %source) { $target{$key} = $value }

[download]

But I imagine Perl is pretty good at handling temporary lists, so I doubt looping through the keys would be as fast.

Update

... and just for fun

Update Again (used the wrong target in the benchmark)

cmpthese( -1, {
   grandfather => sub {
        my %t = %target;
        @t{keys %source} = values %source;
    },
   sleepyjay   => sub {
       my %t = %target;
       %t = ( %t, %source );
    },
   ruzam => sub {
       my %t = %target;
       while ( my($key, $value) = each %source) {
#           $target{$key} = $value   <-- oops!
            $t{$key} = $value 
       }
   },
});

__END__

              Rate   sleepyjay       ruzam grandfather
sleepyjay    905/s          --        -58%        -61%
ruzam       2162/s        139%          --         -8%
grandfather 2349/s        160%          9%          --

[download]

In reply to Re: Merge hash into another hash by ruzam
in thread Merge hash into another hash by GrandFather

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.