The purpose of the API is to be able to return a state indicating whether the sv_2nv works or not (I've removed some code to try and keep to the relevant bits and commented with "mje" tag). As it stands the other types (I removed but are visible at the svn url in previous reply) of SQL_INTEGER and SQL_NUMERIC happily return 1 or 2 if the conversion does not work but SQL_DOUBLE does not.

/* Convert a simple string representation of a value into a more speci
+fic
 * perl type based on an sql_type value.
 * The semantics of SQL standard TYPE values are interpreted _very_ lo
+osely
 * on the basis of "be liberal in what you accept and let's throw in s
+ome
 * extra semantics while we're here" :)
 * Returns:
 *  -2: sql_type isn't handled, value unchanged
 *  -1: sv is undef, value unchanged
 *   0: sv couldn't be cast cleanly and DBIstcf_STRICT was used
 *   1: sv couldn't be cast cleanly and DBIstcf_STRICT was not used
 *   2: sv was cast ok
 */

int
sql_type_cast_svpv(pTHX_ SV *sv, int sql_type, U32 flags, void *v)
{
    int cast_ok = 0;

    switch(sql_type) {

    default:
        return -2;   /* not a recognised SQL TYPE, value unchanged */
 
    case SQL_DOUBLE:    {
        /* mje - I don't understand why sv_2nv returns 0 in the follow
+ing when sv is "aa" */ 
        sv_2nv(sv);
        /* SvNOK should be set but won't if sv is not numeric (in whic
+h
         * case perl would have warn'd already if -w or warnings are i
+n effect)
         */
        /* mje it is true perl warns if sv is "aa" and warnings enable
+d so it knew it was not a number
           so why is cast_ok = 512 */
        cast_ok = SvNOK(sv);
        break;
    }
    }

    if (cast_ok)
        return 2; /* mje always getting here but wanted 0 or 1 dependi
+ng on DBIstcf_STRICT */
    else if (flags & DBIstcf_STRICT)
        return 0;
    else return 1;
}

[download]

UPDATE As it turns out this problem went away in Perl 5.10.1 as SvNOK no longer returns a true value. I think the following change in the changelog for 5.10.1 might be the relevant one:

The public IV and NV flags are now not set if the string value has trailing "garbage". This behaviour is consistent with not setting the public IV or NV flags if the value is out of range for the type.

In reply to Re^8: Why does sv_2nv on non-number look like an NV by mje
in thread Why does sv_2nv on non-number look like an NV by mje

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.