Fixing the bug or the limitation? Fixing the bug is simple:
--- LCSS_XS.xs.orig 2010-01-28 14:00:25.000000000 -0500
+++ LCSS_XS.xs.new 2010-01-28 14:03:45.000000000 -0500
@@ -10,8 +10,8 @@
void
_compute_all_lcss(s, t)
- char * s
- char * t
+ SV * s
+ SV * t
PROTOTYPE: $$
ALIAS:
lcss = 1
@@ -21,7 +21,7 @@
int i;
AV * ra;
PPCODE:
- res = _lcss(s,t);
+ res = _lcss( SvPVbyte_nolen(s), SvPVbyte_nolen(t) );
if (res.n <= 0) {
_free_res(res);
XSRETURN_UNDEF;
It turns out there are two limitations:
- It can only compare strings of bytes
- It can only compare strings that don't contain byte 00. (It and anything after it is ignored.)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.