Is the $file being passed in a filename or a reference ? If it is just a filename, then "set file to the value of $self->{file} already bound." won't work since the value doesn't get back to the caller.

Maybe what you want is for the call in the program to obj->file("Filename"); to store the filename internally, and my $fn = obj->file(); to return it.

If so, your code needs to look more like : 

sub filename
{
   my ($self, $file) = @_;

   $self->{file} = $file if $file;

   return $self->{file};
}

[download]
to get the file back to the caller.

I don't like the $self->{'file'} = shift || $self->{'file'}; idea, since setting something to itself when you don't need to is less clear.
--
Brovnik

In reply to Re: choosing and/or overriding defaults for a sub argument by Brovnik
in thread choosing and/or overriding defaults for a sub argument by princepawn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.