Hello,

I'm attempting to parse XML files with Parse::RecDescent. I'm trying to implement all of the productions described in the XML Spec. I'm concerned about production 14

The production is: [14] CharData ::= [^<&]* - ([^<&]* ']]>' [^<&]*)

Here's what I've implemented for my P::RD grammar:

  CharData : /[^<&]*/
  {
    my $s = $item[1];

    if($s =~ /(.*)(]]>.*)/s) {
      $s = $1;
      $text = $2 . $text;
      Parse::RecDescent::LineCounter::resync($thisline);
    }

    $return = XML::CharData->new($s);
  }

[download]

Note: The class XML::CharData is my own creation.

Could some of you help review this implementation? Is this the correct/best way to implement production 14? It seems to work OK in my unit tests, but it seems very inefficient because it may read a lot of extra data until it hits an "&" or "<".

Thanks, Glen Hein

In reply to P:RD and XML (minor code review) by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.