That's fine, although the logging module usually handles the formatting. It saves you from writing the formating code in every script.
use My::Logger; open(my $log_fh, '>>', 'blah.log') or die "Couldn't open log file."; My::Logger->set_handle($log_fh); My::Logger->log("Processing..."); ... My::Logger->log("done.");
package My::Logger; my $fh = *STDERR; sub set_handle { my ($class, $new_fh) = @_; $fh = $new_fh; } sub log { my $msg = join('', @_); $msg =~ s/\n+\z/\n/; print $fh $msg; } 1;

You might want to let the module handle opening the file too (passing it a file name).


In reply to Re: my homemade solution to logging (module writes to same log file as the script). What do you think? by ikegami
in thread my homemade solution to logging (module writes to same log file as the script). What do you think? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.