UNTESTED rewrite of the first part of your code:
#!/usr/bin/perl use strict; use warnings; # $ENV{PATH} = qq(/usr/sbin:/usr/bin); ?? This makes no sense - it is +unused my %dg; while (qx|vxdg list|) { next if /name/i; $dg { +(split)[0] } = {}; } #my (@hdisks,@sizes,@nodupHdisks,@nodupLuns,@lunid,$svc,$dg,$hdisk,@fs +,$lun); # Process df -k ------------ for my $dfline ( qx|df -k| ) { $dg{ $_} {FS} = +(split $dfline)[6] if $dfline=~/$_/ for keys %df; } for my $dgname (keys %dg){ for my $vxp ( qx|vxprint -thvm -g $dgname |) { $dg{$dgname}{whatever} = value ... ....
This way, you build up the structure %df, and don't execute the same connand repeatedly.

Also , uses qx (backtick equivalent) instead of piped open of command lines.

     Theory is when you know something, but it doesn't work.
    Practice is when something works, but you don't know why it works.
    Programmers combine Theory and Practice: Nothing works and they don't know why.         -Anonymous


In reply to Re: arrays, hoh? by NetWallah
in thread arrays, hoh? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.