Your second match overwrites the captured values from the first match. If you want to keep the values, you need to copy them. Also, you should always check whether your match succeeds before operating on values:

sub test { my $a = shift; die "Malformed value '$a'" if ($a !~ /(.)(.)(.)(..)(.+)/); my ($first,$second,$third,$fourth) = ($1,$2,$3,$4); return 0 if ($first !~ /(a)/); return 0 if ($second !~ /(d|p|t)/); return 0 if ($third !~ /(a|h|r|s|t)/); return 0 if ($fourth !~ /(aw|er|dd|cb|aa)/); }

Alternatively, you could mush the five regular expressions into one:

sub test { my $a = shift; $a =~ /(a)(d|p|t)(a|h|r|s|t)(aw|er|dd|cb|aa)(.+)/; }

You could optimize the regex further by using character classes, that is, writing [dpt] instead of d|p|t.


In reply to Re: What is this erroring out? by Corion
in thread What is this erroring out? by yoda54

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.