The thing to look out for is doing away with the new-line chars as sequence data can be spread across a large number of lines, make it a habit to localize scope for your variables and turn the strictures on, that is a good programming habit, also, check perltidy because, your code has to be readable in order for it to be maintainable later and frankly, your coding style seems good with these indentation however, you skipped to add spaces at "foreach$letter(@seq)"... 
use strict;
use warnings;

my %counts;
my @seq;
local $/='';

while(<DATA>){
        chop;
        s/\n//;
        @seq = split '';
        }

foreach my $element (@seq){
        #count for each DNA base or group foreign letters
        $element =~/[agct]/gi ? $counts{$element}++ : $counts{'N'}++;
        }      

use Data::Dumper;
print Dumper(\%counts);
__DATA__
agcttgtc
agtccxffhhhh

[download]
One final suggestion/exercise, check Benchmark to compare speeds of segments of code in order to decide which one of these proposed approaches is fast(er|est) and pick it up. Though I believe, and would like to be corrected if otherwise, that switch statements are computationally expensive...

Excellence is an Endeavor of Persistence. Chance Favors a Prepared Mind.

In reply to Re: Iterating over string by biohisham
in thread Iterating over string by danielfortin86

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.