Using strictures is good.

Declaring all your variables in one block up front is very bad. Not checking file open is bad. Not using the three parameter version of open is bad. Not using lexical file handles is bad.

Avoid using explicit counters where you don't need to.

Declare variables in the smallest possible scope. Be aware of the last parameter to split and use it where appropriate. Taking all the above into account the following should serve you better:

#!/usr/bin/perl use strict; use warnings; my $outdir = 'D:/share/out'; my $inpath = "D:/share/in/content.txt"; open my $inFile, '<', $inpath or die "Failed to open $inpath: $!"; while (<$inFile>) { chomp; my ($title, $content) = split "\t", $_, 2; my $outpath = "$outdir/$title$."; open my $outFile, '>', $outpath or die "Can't create $outpath: $!" +; print $outFile $content; close $outFile; } close $inFile;

Note in particular the use of the input line number special variable $. (in "$outdir/$title$.") instead of using an explicit counter.

Update: Fix silly open error - thanks jwkrahn

True laziness is hard work

In reply to Re: extract and export to multiple files by GrandFather
in thread extract and export to multiple files by zzgulu

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.