It's not clear where you are having difficulty - your title and most of your question text is at odds with the code you provide. However the following code fixes various errors and fills in missing code. It generates the answer you want and uses Memoize to optimise viterbi's performance by caching results for given arguments lists.

use strict; use warnings; use Memoize qw(); my $trans = { 'end' => {M2 => 1}, 'M2' => {I1 => 0.1, M1 => 0.3}, 'I1' => {begin => 0.8}, 'M1' => {begin => 0.2}, }; Memoize::memoize ('viterbi'); print viterbi('end', 3); sub viterbi { my ($state, $output) = @_; return $output == 0 ? 1 : return 0 if $state eq 'begin'; return 0 if $output == 0; my $r = $output - 1; my $max; for my $yy (keys %{$trans->{$state}}) { my $value = $trans->{$state}->{$yy} * viterbi($yy, $r); $max = $value if ! defined $max || $value > $max; } return $max; }

Prints:

0.08
True laziness is hard work

In reply to Re: how can i hold temporary values in a recursive function by GrandFather
in thread how can i hold temporary values in a recursive function by siskos1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.