#!/usr/local/bin/perl
use strict;
use warnings;
my $file = '/root/Desktop/';
sleep 5;
$file = system("import -window root MyScreenshot.png");
print $file, "\n";
Ouch! That really hurts my eyes!
- Why do you sleep before taking a screenshot?
- Why do you assign a useless constant to $file?
- Are you sure system() returns a file or a filename? Hint: It doesn't!
- So why do you assign the return value to a variable named $file?
- Why do you mess with the notoriously problematic default shell instead of using the multiple-argument form of system?
- Why do you print the return value of system to STDOUT?
At least, you use strict and warnings.
use strict;
use warnings;
system("import -window root MyScreenshot.png");
Better, but still problematic: You still invoke the default shell, begging for trouble. All error checks are missing. Yes, system() may fail. For example, because there is no import utility -- e.g. when ImageMagick is not installed. Or because there is some other tool named import, with completely different parameters a and a completely different purpose.
Alexander
--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.